Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ros2_control_node] Add option to set the CPU affinity (backport #1852) #1857

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 5, 2024

This PR adds an option to the ros2_control_node to be able to set the CPU affinity to bind it to a specific CPU Core. By default, this is not enabled, unless it is specifically set


This is an automatic backport of pull request #1852 done by Mergify.

Copy link
Contributor Author

mergify bot commented Nov 5, 2024

Cherry-pick of 98f0795 has failed:

On branch mergify/bp/iron/pr-1852
Your branch is up to date with 'origin/iron'.

You are currently cherry-picking commit 98f0795.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   controller_manager/src/ros2_control_node.cpp

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   doc/release_notes.rst

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot added the conflicts label Nov 5, 2024
@saikishor
Copy link
Member

saikishor commented Nov 5, 2024

Needs to be merged after #1851

@saikishor
Copy link
Member

@mergify rebase

Copy link
Contributor Author

mergify bot commented Nov 5, 2024

rebase

☑️ Nothing to do

  • -conflict [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • queue-position = -1 [📌 rebase requirement]
  • any of:
    • #commits-behind > 0 [📌 rebase requirement]
    • #commits > 1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]

Copy link
Contributor Author

mergify bot commented Nov 5, 2024

This pull request is in conflict. Could you fix it @bmagyar @destogl @christophfroehlich @saikishor?

@saikishor saikishor force-pushed the mergify/bp/iron/pr-1852 branch from 000cb8b to 5e9b4b6 Compare November 5, 2024 12:06
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 62.32%. Comparing base (a52f800) to head (5e9b4b6).
Report is 1 commits behind head on iron.

Files with missing lines Patch % Lines
controller_manager/src/ros2_control_node.cpp 16.66% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             iron    #1857      +/-   ##
==========================================
- Coverage   62.34%   62.32%   -0.03%     
==========================================
  Files         112      112              
  Lines       13102    13108       +6     
  Branches     8886     8888       +2     
==========================================
+ Hits         8169     8170       +1     
- Misses        948      951       +3     
- Partials     3985     3987       +2     
Flag Coverage Δ
unittests 62.32% <16.66%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 68.88% <16.66%> (-8.04%) ⬇️

... and 2 files with indirect coverage changes

@bmagyar bmagyar merged commit 7797a38 into iron Nov 5, 2024
8 of 12 checks passed
@bmagyar bmagyar deleted the mergify/bp/iron/pr-1852 branch November 5, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants